Fix bug in delete_nodes when passing pks of non-existing nodes
#2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_2439_delete_nodes_not_existing
branch
from
eb8d826 to
1ecefe6
Compare
| try: | ||
| load_node(pk) | ||
| except exceptions.NotExistent: | ||
| print('warning: node with pk<{}> does not exist, skipping'.format(pk)) |
There was a problem hiding this comment.
Shouldn't we use click.echo?
There was a problem hiding this comment.
Didn't touch that part, but might as well, you are right
The `aiida.manage.database.delete.nodes.delete_nodes` function was not checking whether the pks that were passed correspond to existing nodes which would cause the line that fetches the repository folders, after the graph traversal queries had been completed, to except. To fix this we first verify that the passed pks exist and if not print a warning and discard them.
sphuber
force-pushed
the
fix_2439_delete_nodes_not_existing
branch
from
1ecefe6 to
802f5ba
Compare
|
@giovannipizzi Changed |
giovannipizzi
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2439
The
aiida.manage.database.delete.nodes.delete_nodesfunction was notchecking whether the pks that were passed correspond to existing nodes
which would cause the line that fetches the repository folders, after
the graph traversal queries had been completed, to except. To fix this
we first verify that the passed pks exist and if not print a warning and
discard them.