Implement verdi database migrate
#2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
approved these changes
Dec 11, 2018
Up till now, the triggering of a database migration happened through separate interfaces for the two different backends. For Django, if the database schema did not match the code's, a warning message would be printed asking the user to execute a stand alone python script that was a modified Django `manage.py` script. For SqlAlchemy, the user was automatically prompted with an Alembic migration. Here we unify the migration operation by making it go through `verdi` through the endpoint `verdi database migrate`. The error message upon an outdated database schema and the to be executed commands are now identical for both backends.
sphuber
force-pushed
the
fix_2332_verdi_database_migrate
branch
from
82fe4dd to
60b6feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2332
Up till now, the triggering of a database migration happened through
separate interfaces for the two different backends. For Django, if
the database schema did not match the code's, a warning message would
be printed asking the user to execute a stand alone python script that
was a modified Django
manage.pyscript. For SqlAlchemy, the user wasautomatically prompted with an Alembic migration.
Here we unify the migration operation by making it go through
verdithrough the endpoint
verdi database migrate. The error message uponan outdated database schema and the to be executed commands are now
identical for both backends.