Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforced the behavior of queries to ressemble backend, by disallowing deduplication of results by SQLAlchemy #2281

Merged

Conversation

lekah
Copy link
Contributor

@lekah lekah commented Dec 4, 2018

This resolves #1600, by forcing SQLAlchemy to not de-duplicate rows. Therefore, the backend (psql) behavior is more closely reproduced, and we have the following equality:

qb.count() == len(qb.all())

A test for this was added.

…te rows. Therefore, the backend (psql) behavior is more closely reproduced.
@lekah lekah requested a review from giovannipizzi December 4, 2018 08:57
Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@sphuber sphuber merged commit 13dcc03 into aiidateam:provenance_redesign Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants