-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
differentiate quicksetup based on project folder #1901
Conversation
9fef0e3
to
eb320df
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1901 +/- ##
===========================================
+ Coverage 66.82% 66.82% +<.01%
===========================================
Files 320 320
Lines 32590 32592 +2
===========================================
+ Hits 21778 21780 +2
Misses 10812 10812
Continue to review full report at Codecov.
|
|
||
# default database user name is aiida_qs_<login-name> | ||
# default password is random | ||
dbuser = db_username or 'aiida_qs_' + osuser | ||
dbuser = db_username or 'aiida_qs_' + osuser + '_' + aiida_base_dir_hash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that it makes sense to use a different DB for different config folders.
If the DB is already different, do we still need to append the hash to the username?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact the username is just as important: if it already exists (from another config.json), there is no way to know the password stored in the other config.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, I forgot that the user names are system-wide.
eb320df
to
8e4c01d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright with me - your choice whether you want to check with sebastiaan
Problem:
When using quicksetup with a custom location for the .aiida/ config folder, it might try to create and use an existing dbuser with a new password, causing naive use of quicksetup to fail.
Solution:
Add a uuid of the current
AIIDA_PATH
folder to the db user and db name during quicksetup.