Fix sphinxext command by allowing whitespace in argument #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this command used a fixed number of 'optional' arguments, which contained the signature of the WorkChain split by whitespace. By allowing whitespace in the argument, it can be passed as a single argument, making the directive stable w.r.t. adding / removing arguments in the workchain __init__.
Codecov Report
@@ Coverage Diff @@
## develop #1644 +/- ##
===========================================
+ Coverage 57.18% 57.18% +<.01%
===========================================
Files 274 274
Lines 33834 33835 +1
===========================================
+ Hits 19348 19349 +1
Misses 14486 14486
Continue to review full report at Codecov.
|
sphuber
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this command used a fixed number of 'optional' arguments, which contained the signature of the WorkChain split by whitespace.
By allowing whitespace in the argument, it can be passed as a single argument, making the directive stable w.r.t. adding / removing arguments in the workchain
__init__.