New AuthInfo ORM class #1184
Merged
New AuthInfo ORM class #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
between checks for a transport defined in a more global way. Also, run yapf on the scheduler and transport submodules.
… new system using RMQ
database-level class. I think this commit is still not working (not tested at all yet), as I had to refactor a large part of the code and most probably I missed something. I will start testing as the next step, and add tests for the new functionality.
dict (but to None) in SQLA
the Wf was defined inside another class and couldn't be imported. Weirdly, I saw the problem only locally and not on travis...
…urable_check_time
indicate a merge conflict
also improving the Capturing object to optionally capture also stderr.
…5_new_authinfo_orm_class
sphuber
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test adds a new ORM class for AuthInfo; all the code now uses AuthInfo instead of DbAuthInfo directly.
This is in preparation for #995 but this PR does not yet implement a way to change the times.
Note that in merging I put back 30 seconds for SSH, as if we leave 5 seconds it's clearly a problem for real supercomputers (even if I understand 5 is good for testing).