Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: restrict pydantic to at least 1.10.8 #941

Merged
merged 1 commit into from
May 24, 2023

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented May 24, 2023

The release of typing_extensions version 4.6.0 highlighted a bug in pydantic related to the Literal type for Python versions 3.8 and 3.9. This was fixed in pydantic version 1.10.8.

Here the version of pydantic is set to be a compatible release with 1.10 but at least 1.10.8.

The release of `typing_extensions` version `4.6.0` highlighted a bug in
`pydantic` related to the `Literal` type for Python versions 3.8 and 3.9.
This was fixed in `pydantic` version `1.10.8`.

Here the version of `pydantic` is set to be a compatible release with `1.10`
but at least `1.10.8`.
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it was indeed a bug in pydantic, seems reasonable to add a lower limit. Thanks @mbercx

@mbercx mbercx marked this pull request as ready for review May 24, 2023 17:27
@mbercx mbercx merged commit f430139 into aiidateam:main May 24, 2023
@mbercx mbercx deleted the deps/pydantic branch May 24, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants