Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PwBandsWorkChain: default diagonalization set to 'cg'? #830

Closed
mbercx opened this issue Jul 27, 2022 · 1 comment · Fixed by #902
Closed

PwBandsWorkChain: default diagonalization set to 'cg'? #830

mbercx opened this issue Jul 27, 2022 · 1 comment · Fixed by #902

Comments

@mbercx
Copy link
Member

mbercx commented Jul 27, 2022

The PwBandsWorkChain automatically sets the diagonalization setting to 'cg' inside the run_bands step of the outline:

# Only set the following parameters if not directly explicitly defined in the inputs
inputs.pw.parameters['ELECTRONS'].setdefault('diagonalization', 'cg')
inputs.pw.parameters['ELECTRONS'].setdefault('diago_full_acc', True)

  1. I think it would be better if this default is moved to the protocol.
  2. We should consider changing this default. It's true that 'cg' is more robust, but also more expensive. There are also newer diagonalization options to consider, see the pw.x documentation.

We'll have to check which diagonalization algorithms have been added since v6.5 (the oldest version we'll support for v4.X of the plugin), and do a bit of testing to see what default would be the most sensible.

@mbercx
Copy link
Member Author

mbercx commented Jul 27, 2022

Unfortunately 'paro' has only been implemented since v6.6:

https://gitlab.com/QEF/q-e/-/releases#new-in-v-66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant