From 9568138bc5ed7f20eca1bd3c15a411c484971fa7 Mon Sep 17 00:00:00 2001 From: Sebastiaan Huber Date: Sun, 6 Mar 2022 22:45:22 +0100 Subject: [PATCH] Correct version number for RabbitMQ warning Recently, a warning was added when a RabbitMQ installation was used with a version of 3.8 or higher. This was done because a consumer default timeout was added to the server configuration that would cause unacked messages to be requeued after only 15 minutes. However, this change was only added in 3.9: https://github.com/rabbitmq/rabbitmq-server/commit/80e399212eb35d24969e869d80db60b706e59af3 and was backported in the v3.8 minor version in v3.8.15. Therefore, we can relax the condition for the warning to be shown only when the version is 3.8.15 or higher. --- aiida/manage/manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aiida/manage/manager.py b/aiida/manage/manager.py index 986f41f30d..3cacdd564b 100644 --- a/aiida/manage/manager.py +++ b/aiida/manage/manager.py @@ -446,7 +446,7 @@ def check_rabbitmq_version(communicator: 'RmqThreadCommunicator'): from aiida.cmdline.utils import echo version = get_rabbitmq_version(communicator) - if version >= parse('3.8'): + if version >= parse('3.8.15'): echo.echo_warning(f'RabbitMQ v{version} is not supported and will cause unexpected problems!') echo.echo_warning('It can cause long-running workflows to crash and jobs to be submitted multiple times.') echo.echo_warning('See https://github.com/aiidateam/aiida-core/wiki/RabbitMQ-version-to-use for details.')