Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine cause for importance of order in state update in Process.on_entered #5817

Open
sphuber opened this issue Dec 5, 2022 · 0 comments
Open

Determine cause for importance of order in state update in Process.on_entered #5817

sphuber opened this issue Dec 5, 2022 · 0 comments
Labels
priority/quality-of-life would simplify development topic/processes type/question may redirect to mailinglist

Comments

@sphuber
Copy link
Contributor

sphuber commented Dec 5, 2022

In #5813 a very subtle bug was fixed that was introduced by swapping the order in which the outputs of the node and the process state attribute were updated. Reverting the order would cause the nightly workflow to fail since one of the many workchains that would be run would fail because one of the subprocesses (although finished successfully) would not have the outputs attached. For now the order is reversed to the original order which fixes the problem, but it is not understood why the order matters at all.
@sphuber sphuber added type/question may redirect to mailinglist priority/quality-of-life would simplify development topic/processes labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/quality-of-life would simplify development topic/processes type/question may redirect to mailinglist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sphuber