Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use Profile.repository_uri as the location for sandbox creation #5494

Closed
sphuber opened this issue Apr 23, 2022 · 1 comment · Fixed by #5496
Closed

Do not use Profile.repository_uri as the location for sandbox creation #5494

sphuber opened this issue Apr 23, 2022 · 1 comment · Fixed by #5496
Assignees
@sphuber
Labels
priority/nice-to-have topic/config type/refactoring
Milestone
v2.1.0

Comments

@sphuber
Copy link
Contributor

sphuber commented Apr 23, 2022

The repository_uri key in a profile configuration is used for two purposes. It is the base path for both the repository container, but also for the directory where SandBoxFolders are created. Really this key should only be used for the location of the repository. The location of the sandbox folders should simply be in the tmp folder of the operating system. This decoupling will make it possible to introduce storage backends in the future that do not have a path on the local file system for a file repository.
@sphuber sphuber self-assigned this Apr 23, 2022
This was referenced Apr 23, 2022
Merged
Merged
@chrisjsewell
Copy link
Member

this is a duplicate of #5353

@sphuber sphuber added this to the v2.1 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/nice-to-have topic/config type/refactoring
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

SandboxFolder: remove option to create in profile repository sphuber/aiida-core
2 participants
@chrisjsewell @sphuber