Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entry_point attribute to Node and Group classes. #4939

Closed
mbercx opened this issue May 10, 2021 · 1 comment · Fixed by #5437
Closed

Add entry_point attribute to Node and Group classes. #4939

mbercx opened this issue May 10, 2021 · 1 comment · Fixed by #5437
Labels
good first issue Issues that should be relatively easy to fix also for beginning contributors priority/nice-to-have topic/orm type/enhancement
Milestone

Comments

@mbercx
Copy link
Member

mbercx commented May 10, 2021

Is your feature request related to a problem? Please describe

When I first wanted to obtain the entry point from a Group instance, I intuitively looked for the entry_point attribute. However, it seems that the entry point of a Group type can be obtained with the type_string attribute instead. Is there a difference between the type_string and the entry point? If not, perhaps we can add an alias for this attribute called entry_point?

For Node instances, I don't seem to find an attribute or method that directly returns the entry point. There is node_type and class_node_type, but they return something along the lines of '<entry point group>.<entry point>.<class name>' e.g. 'data.structure.StructureData.'. So, the user would have to understand this structure and adapt the output accordingly.

Describe your desired solution

I think it would be useful for users and developers if we can obtain the entry point for any object that has one with an entry_point attribute. Since users learn about entry points early on, it seems more intuitive to obtain a Node or Group's entry point via an attribute with the same name.

@mbercx mbercx added good first issue Issues that should be relatively easy to fix also for beginning contributors priority/nice-to-have type/enhancement topic/orm labels May 10, 2021
@chrisjsewell
Copy link
Member

I agree 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that should be relatively easy to fix also for beginning contributors priority/nice-to-have topic/orm type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants