Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_node(1) != load_node(1) ... The node should be equal to itself. #4736

Closed
yakutovicha opened this issue Feb 9, 2021 · 4 comments
Closed
Labels

Comments

@yakutovicha
Copy link
Contributor

Describe the bug

In [1]: load_node(1) == load_node(1)
Out[1]: False

Expected behaviour

In [1]: load_node(1) == load_node(1)
Out[1]: True
@greschd
Copy link
Member

greschd commented Feb 9, 2021

I think this is a duplicate of #1917.

Note that there's some argument there about what exactly the equality operator should do, but I think we agree that the same nodes should compare equal.

@yakutovicha
Copy link
Contributor Author

heh, sorry, I was searching for some words like 'equal', but didn't find the issue. Thanks @greschd

@greschd
Copy link
Member

greschd commented Feb 9, 2021

Yeah no problem, it's good that we good a ping about fixing that issue.

Since we were looking for broader feedback (see this comment), would be great to also hear your opinion on that.

@yakutovicha
Copy link
Contributor Author

yakutovicha commented Feb 9, 2021

Yeah no problem, it's good that we good a ping about fixing that issue.

Since we were looking for broader feedback (see this comment), would be great to also hear your opinion on that.

I am currently going through. And I feel exactly as @giovannipizzi wrote (c):

I have to admit that while reading it, at every comment I thought "ok we should do this" and at the following "ah right, wait!"...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants