Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import / Export without empty directories #3764

Closed
PhilippRue opened this issue Feb 17, 2020 · 5 comments · Fixed by #4345
Closed

Import / Export without empty directories #3764

PhilippRue opened this issue Feb 17, 2020 · 5 comments · Fixed by #4345
Assignees
Milestone

Comments

@PhilippRue
Copy link
Contributor

For some nodes AiiDA generates empty directories in the repository.
In my case I removed some of these to reduce the number of inodes I have. The database export and import now poses a problem since it runs into these (false positive) exception:

raise exceptions.ArchiveExportError(

and

It would probably be good to not require empty directories to be included in import/export files.

@ltalirz
Copy link
Member

ltalirz commented Feb 17, 2020

@sphuber Let's discuss whether it perhaps makes sense to - until the repo migration - add a "lazy" node folder creation that only creates node folders when something should be put inside.

@CasperWA
Copy link
Contributor

I agree - and it should be a fairly easy(TM) fix in the end. I can try and knock it out.

@CasperWA CasperWA self-assigned this Feb 17, 2020
@ltalirz
Copy link
Member

ltalirz commented Feb 17, 2020

One comment by @sphuber : Since we are currently not tracking the content of folders, this change would mean that we are no longer able to detect whether the folder was (e.g. accidentally) deleted.

I.e. we should weigh whether the reduction in inodes is worth giving up this consistency check (which is of course quite basic - e.g. missing files are anyhow not detected).

Perhaps @giovannipizzi can comment

@ltalirz
Copy link
Member

ltalirz commented Oct 29, 2020

This will be addressed by the new archive format aiidateam/AEP#21

@chrisjsewell chrisjsewell linked a pull request Nov 11, 2020 that will close this issue
@chrisjsewell
Copy link
Member

Heya, I've marked this a being closed by: #3445.
This is because with this new repository system there will actually no longer be a folder system on disk; files are stored in a compressed format (indexed by hash), with the node's database entry containing a virtual mapping of the actual file/folder structure.

Let's discuss whether it perhaps makes sense to - until the repo migration - add a "lazy" node folder creation that only creates node folders when something should be put inside.

I very much doubt anyone's going to have time to do this now, it'll just be wasted effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants