Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python 2 support #3562

Closed
sphuber opened this issue Nov 21, 2019 · 3 comments · Fixed by #3566
Closed

Drop python 2 support #3562

sphuber opened this issue Nov 21, 2019 · 3 comments · Fixed by #3566
Assignees
@sphuber
Labels
priority/critical-blocking must be resolved before next release type/refactoring
Milestone
v1.1.0

Comments

@sphuber
Copy link
Contributor

sphuber commented Nov 21, 2019

No description provided.

@sphuber sphuber added this to the v1.1.0 milestone Nov 21, 2019
@sphuber sphuber self-assigned this Nov 21, 2019
@greschd
Copy link
Member

greschd commented Nov 21, 2019 •
edited
Loading

Relevant link: https://packaging.python.org/guides/dropping-older-python-versions/
TL;DR: Use the python_requires=">=3" kwarg in setup to make build tools aware of the incompatibility.

@sphuber
Copy link
Contributor Author

sphuber commented Nov 21, 2019

I think we can even be a bit more specific and set >=3.5 since 3.4 is EOL since March 2019

@greschd
Copy link
Member

greschd commented Nov 21, 2019

Yeah, whichever version we decide to support, of course.

@sphuber sphuber mentioned this issue Nov 21, 2019
Merged
@greschd greschd mentioned this issue Dec 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/critical-blocking must be resolved before next release type/refactoring
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Drop python 2 sphuber/aiida-core
2 participants
@greschd @sphuber