Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the execmanager.retrieve_calculation idempotent as best as possible #3141

Closed
sphuber opened this issue Jul 7, 2019 · 0 comments · Fixed by #3142
Closed

Make the execmanager.retrieve_calculation idempotent as best as possible #3141

sphuber opened this issue Jul 7, 2019 · 0 comments · Fixed by #3142

Comments

@sphuber
Copy link
Contributor

sphuber commented Jul 7, 2019

The retrieve_calculation will attempt to retrieve all the files once a calculation job has finished and store them in a FolderData node that is attached to the CalcJobNode with the retrieved link label. However, if the daemon runner is shutdown and is interrupted during this method, when it reload the process, it will call the same retrieve_calculation and will try to attach once again a node with the retrieved label. This will cause an exception, because the output label has to be unique. To solve it, the attachment of the FolderData should be done at the very end and a check should be added in the beginning for the existence of the output node, in which case it should be a no-op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant