Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the SqlAlchemy and Django QueryBuilder implementation #3082

Closed
sphuber opened this issue Jun 25, 2019 · 3 comments · Fixed by #5093
Closed

Refactor the SqlAlchemy and Django QueryBuilder implementation #3082

sphuber opened this issue Jun 25, 2019 · 3 comments · Fixed by #5093
Labels
priority/quality-of-life would simplify development topic/query-builder type/refactoring

Comments

@sphuber
Copy link
Contributor

sphuber commented Jun 25, 2019

No description provided.

@sphuber sphuber mentioned this issue Jun 25, 2019
Closed
@muhrin
Copy link
Contributor

muhrin commented Dec 10, 2019

@sphuber Is this issue still being tracked? It is clear what needs to be done?

@sphuber
Copy link
Contributor Author

sphuber commented Dec 10, 2019

Not sure, but I think the original idea was that there was quite some overlap in the implementations that could just be moved to aiida.orm.querybuilder.QueryBuilder instead

@muhrin
Copy link
Contributor

muhrin commented Dec 10, 2019

Ok, then it sounds related to #3632 which I just opened. My perferred route would be to have something like a RelationalBackendQueryBuilder that is a base class for both.

@chrisjsewell chrisjsewell mentioned this issue Aug 12, 2021
Closed
@chrisjsewell chrisjsewell linked a pull request Aug 24, 2021 that will close this issue
♻️ REFACTOR: Fully abstract QueryBuilder #5093
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/quality-of-life would simplify development topic/query-builder type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻️ REFACTOR: Fully abstract QueryBuilder chrisjsewell/aiida_core
2 participants
@muhrin @sphuber