Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the User database model #2928

Closed
sphuber opened this issue May 27, 2019 · 5 comments · Fixed by #2944
Closed

Simplify the User database model #2928

sphuber opened this issue May 27, 2019 · 5 comments · Fixed by #2944

Comments

@sphuber
Copy link
Contributor

sphuber commented May 27, 2019

The current User entity is mostly used to add the metadata of the owner to a Node. However, it includes various attributes related to using the instance as way to authenticate and authorize. This was originally added because the base user implementation provided by Django was used, which requires these additional fields. If Django can be used with a simplified model, this would be better. The only attributes we need:

  • id
  • email
  • first name
  • last name
  • institution
@sphuber
Copy link
Contributor Author

sphuber commented May 27, 2019

Question @ltalirz and @giovannipizzi : we didn't discuss if having first and last name as separate attributes is necessary. These things traditionally can be pitfalls. Not all people have a name that falls into this category. Take my own name for example. I would need to include my middle name to match my academic publishing name. Where do I put it? This is also the reason why git just has "name". I propose we simplify further to just a single attribute name.

@giovannipizzi
Copy link
Member

ok for me

@ltalirz
Copy link
Member

ltalirz commented May 27, 2019

I'm ok with the change (name = first name + last name) in general but I would hesitate to include this in 1.0.
I don't think it's a necessary change and it might break some things (e.g. yml files for verdi quicksetup).
Anyhow, I'm open to discussion.

@CasperWA
Copy link
Contributor

Note for import/export:
This will not change anything for import/export, since only: "last_name", "first_name", "institution", and "email" are (and have been) exported.

@sphuber
Copy link
Contributor Author

sphuber commented May 28, 2019

Decision has been made to merge first_name and last_name into single name column, but since this will introduce breaking changes, we will mark this for release v2.0.0 see #2945

@sphuber sphuber added this to the v1.0.0 milestone May 28, 2019
@sphuber sphuber self-assigned this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants