Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that version number is increased correctly #2790

Closed
szoupanos opened this issue Apr 22, 2019 · 1 comment
Closed

Ensure that version number is increased correctly #2790

szoupanos opened this issue Apr 22, 2019 · 1 comment
Assignees
@sphuber @giovannipizzi
Labels
type/question may redirect to mailinglist
Milestone
v1.0.0

Comments

@szoupanos
Copy link
Contributor

This is not necessarily something that is done wrong but an issue to discuss to ensure that we have the correct behaviour.

This came to my attention with the implementation of Django JSONB project. Currently we increase the version number in SQLA when set, reset or delete attribute(s).

However, in Django we increase the node version number only on set and reset (and not on delete). The same behaviour was replicated in Django JSONB.

Which is the correct behaviour and why?
@szoupanos @sphuber @ltalirz @giovannipizzi
@szoupanos szoupanos added this to the v1.0.0 milestone Apr 22, 2019
@ltalirz ltalirz added the type/question may redirect to mailinglist label Apr 22, 2019
@sphuber
Copy link
Contributor

sphuber commented May 30, 2019

This has become obsolete because the nodeversion column has been dropped in PR #2937

@sphuber sphuber closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

@giovannipizzi giovannipizzi

Labels
type/question may redirect to mailinglist
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
4 participants
@ltalirz @sphuber @giovannipizzi @szoupanos