Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign the interface of the local_copy_list of the CalcInfo data structure #2573

Closed
sphuber opened this issue Mar 5, 2019 · 1 comment
Closed

Redesign the interface of the local_copy_list of the CalcInfo data structure #2573

sphuber opened this issue Mar 5, 2019 · 1 comment
Assignees
@sphuber
Labels
priority/critical-blocking must be resolved before next release topic/calc-jobs type/accepted feature approved feature request type/refactoring
Milestone
v1.0.0

Comments

@sphuber
Copy link
Contributor

sphuber commented Mar 5, 2019 •
edited
Loading

Currently, the developer of a CalcJob plugin is expected to define the local_copy_list and assign them to the CalcInfo data structure that is returned by the CalcJob.prepare_for_submission method. This local_copy_list should be a list of tuples, where each tuple specifies a local absolute path and a remote relative path. However, with the upcoming change of the repository, it is no longer guaranteed to have a local absolute path on the file system for node files and so the interface only provides methods to get a filelike object or the complete content.
@sphuber sphuber added priority/critical-blocking must be resolved before next release type/accepted feature approved feature request type/refactoring topic/calc-jobs labels Mar 5, 2019
@sphuber sphuber added this to the v1.0.0b1 milestone Mar 5, 2019
@sphuber sphuber self-assigned this Mar 5, 2019
@sphuber sphuber modified the milestones: v1.0.0b1, v1.0.0 Mar 5, 2019
@sphuber sphuber changed the title Redesign the interface of the various file lists of CalcInfo Redesign the interface of the local_copy_list of the CalcInfo data structure Mar 6, 2019
@sphuber sphuber mentioned this issue Mar 6, 2019
Merged
@sphuber
Copy link
Contributor Author

sphuber commented Mar 7, 2019

Fixed in PR #2581

@sphuber sphuber closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/critical-blocking must be resolved before next release topic/calc-jobs type/accepted feature approved feature request type/refactoring
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@sphuber