Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ParameterData to Dict #2398

Closed
sphuber opened this issue Jan 17, 2019 · 1 comment
Closed

Rename ParameterData to Dict #2398

sphuber opened this issue Jan 17, 2019 · 1 comment
Assignees
@sphuber
Labels
priority/important requires discussion topic/naming-issues type/refactoring
Milestone
v1.0.0b1

Comments

@sphuber
Copy link
Contributor

sphuber commented Jan 17, 2019

Exactly what it says on the tin. The name ParameterData is often found confusing, especially when it is used as an output of a calculation. Given that we already have List, the name Dict describes exactly what it is and also directly mirrors the python built in data structure.
@sphuber sphuber added this to the v1.0.0b1 milestone Jan 17, 2019
@sphuber sphuber mentioned this issue Feb 22, 2019
Closed
@sphuber sphuber self-assigned this Feb 25, 2019
@sphuber sphuber mentioned this issue Feb 25, 2019
Merged
@sphuber
Copy link
Contributor Author

sphuber commented Feb 26, 2019

Fixed in PR #2530

@sphuber sphuber closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/important requires discussion topic/naming-issues type/refactoring
Projects
None yet
Milestone
v1.0.0b1
Development

No branches or pull requests
1 participant
@sphuber