Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobProcess task_retrieve_job is not idempotent which can cause failures #2265

Closed
muhrin opened this issue Dec 3, 2018 · 1 comment
Closed

JobProcess task_retrieve_job is not idempotent which can cause failures #2265

muhrin opened this issue Dec 3, 2018 · 1 comment
Assignees
@sphuber
Labels
priority/important topic/calc-jobs

Comments

@muhrin
Copy link
Contributor

muhrin commented Dec 3, 2018

The retrieval task can fail if it is executed for a second time. This happens when a the retrieved files node is attached to the job for a second time causing a uniqueness violation.

If we know that, by the time the link is being created, the retrieved files node is correctly set up then we could just reuse the one we find from last time, effectively ignoring the uniqueness violation and using the current node.
@muhrin muhrin added this to the v1.1.0 milestone Dec 3, 2018
@sphuber sphuber removed this from the v1.1.0 milestone Feb 28, 2020
@sphuber sphuber self-assigned this Oct 4, 2020
@sphuber
Copy link
Contributor

sphuber commented Oct 4, 2020

This was addressed in #3142

@sphuber sphuber closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/important topic/calc-jobs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muhrin @sphuber