Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload the mutable properties of a PortNamespace when exposing it #1634

Closed
sphuber opened this issue Jun 8, 2018 · 1 comment · Fixed by #1635
Closed

Overload the mutable properties of a PortNamespace when exposing it #1634

sphuber opened this issue Jun 8, 2018 · 1 comment · Fixed by #1635
Assignees
Milestone

Comments

@sphuber
Copy link
Contributor

sphuber commented Jun 8, 2018

When exposing the ports of a process one would expect that the receiving port namespace would not just inherit the ports but also the mutable properties of the donor PortNamespace, such as the default, valid_type, help, validator and required attribute. Currently this is not the case. Additionally, any newly created namespaces will just receive the default properties. It would be good if both the inherited properties as well as those of a newly created namespace could be overridden from the expose call itself.

@sphuber sphuber added this to the v1.0.0 milestone Jun 8, 2018
@sphuber sphuber self-assigned this Jun 8, 2018
@sphuber sphuber changed the title Allow PortNamespace created through exposure to be marked as non-required Overload the mutable properties of a PortNamespace when exposing it Jun 8, 2018
@sphuber
Copy link
Contributor Author

sphuber commented Jun 21, 2018

Fixed in PR #1635

@sphuber sphuber closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant