Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code hidden attribute migration breaks on SqlAlchemy #1290

Closed
sphuber opened this issue Mar 17, 2018 · 0 comments
Closed

Code hidden attribute migration breaks on SqlAlchemy #1290

sphuber opened this issue Mar 17, 2018 · 0 comments
Assignees
@sphuber
Labels
priority/critical-blocking must be resolved before next release topic/database-sqlalchemy type/bug
Milestone
v1.0.0

Comments

@sphuber
Copy link
Contributor

sphuber commented Mar 17, 2018

The database migration that was added in PR #1111 to move the hidden field from the attributes of Code nodes to the extras, was written for SqlAlchemy using the models. This will break if in the future the model will change, which is very likely. Instead the migration should be performed with raw SQL which does not depend on the state of the models during the migrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/critical-blocking must be resolved before next release topic/database-sqlalchemy type/bug
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@sphuber