Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow None as argument defaults in FunctionCalculations #1210

Closed
sphuber opened this issue Feb 28, 2018 · 1 comment
Closed

Allow None as argument defaults in FunctionCalculations #1210

sphuber opened this issue Feb 28, 2018 · 1 comment
Assignees
@sphuber
Labels
priority/nice-to-have requires discussion topic/workflows
Milestone
v1.0.0

Comments

@sphuber
Copy link
Contributor

sphuber commented Feb 28, 2018

The old optional_inline decorator allowed writing a generic python function with optionally None as default for function arguments, that could still be called as an InlineCalculation. Now that those are routed through the process layer, that is no longer allowed and so optional inline functions can no longer take non database storable types as function argument defaults.
@sphuber sphuber added this to the v0.12.0 milestone Feb 28, 2018
@sphuber sphuber self-assigned this Feb 28, 2018
@sphuber sphuber mentioned this issue Mar 6, 2019
Merged
@sphuber
Copy link
Contributor Author

sphuber commented Mar 7, 2019

Fixed in PR #2582

@sphuber sphuber closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/nice-to-have requires discussion topic/workflows
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@sphuber @giovannipizzi