CI fix: Test on push to master branch, not main! #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
==========================================
- Coverage 96.21% 96.19% -0.02%
==========================================
Files 11 11
Lines 1188 1183 -5
==========================================
- Hits 1143 1138 -5
Misses 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
requested review from
unkcpz and
superstar54
and removed request for
unkcpz
|
Going to merge this to unblock the other PRs. |
Recently released version ase 3.23 broke one of our tests that hardcodes a binary output from ase.Atoms.write. I opened aiidalab#612 with more details.
danielhollas
force-pushed
the
test-on-master
branch
from
7c1d5e6
to
b46b963
Compare
|
Ha, interesting~ I am wondering anyelse |
|
I am not aware of any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't been running CI on pushes to master since #573, whoops!
My bad. 😢
I also needed to pin the ASE version since the recently released version 3.23 broke one of our tests that hardcodes a binary output from ase.Atoms.write. I opened #612 with more details.