Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of default computer in ComputationalResourcesDatabaseWidget #601

Merged
merged 2 commits into from
May 15, 2024
Merged

Fix handling of default computer in ComputationalResourcesDatabaseWidget #601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1ddad8
Fix ComputationalResourcesDatabaseWidget
yakutovicha May 14, 2024
3f342f0
Merge branch 'master' into fix/computational-resources-db-widget
yakutovicha May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions aiidalab_widgets_base/databases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,9 +353,7 @@ def _database_generator(database_source, default_calc_job_plugin):
if len(domain_value) == 0:
# remove domain since no computers with required codes defined in this domain source
del database[domain]
continue

if domain_value["default"] not in domain_value:
elif domain_value.get("default") not in domain_value:
# make sure default computer is still points to existing computer
domain_value["default"] = sorted(domain_value.keys() - {"default"})[0]

Expand Down