Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with aiida-core=2.5 #599

Merged
merged 26 commits into from
May 27, 2024
Merged

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented May 8, 2024

  • test aiida-core 2.5.1
  • update test requirements
  • squash some deprecations warnings

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (7c9a3ef) to head (49ddca6).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
- Coverage   96.21%   96.19%   -0.02%     
==========================================
  Files          11       11              
  Lines        1188     1183       -5     
==========================================
- Hits         1143     1138       -5     
  Misses         45       45              
Flag Coverage Δ
python-3.10 96.19% <100.00%> (-0.02%) ⬇️
python-3.9 96.19% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas marked this pull request as draft May 8, 2024 17:18
@danielhollas danielhollas marked this pull request as ready for review May 15, 2024 20:04
def fixture_localhost(aiida_localhost):
"""Return a localhost `Computer`."""
localhost = aiida_localhost
localhost.set_default_mpiprocs_per_machine(1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the source code of the aiida_localhost fixture, and it seems to set this up by default, so I am not sure why this was here...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember the fixture was directly copied from https://github.com/aiidateam/aiida-quantumespresso/blob/7b6c210a80942aed8ed08fa78f0d123d3227e750/tests/conftest.py#L42
Maybe it is not needed anymore? Then we can also remove it from aiida-quantumespresso.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good to know, thanks. Looking at git blame, that fixture is five years old, so indeed most likely can be removed from there as well.

@danielhollas danielhollas requested a review from unkcpz May 15, 2024 20:08
@danielhollas
Copy link
Contributor Author

Merging this since the changes here are low-risk and we want to start testing with 2.5.

@danielhollas danielhollas merged commit d8a95dd into aiidalab:master May 27, 2024
11 checks passed
@danielhollas danielhollas deleted the test-2.5 branch May 27, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants