Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mock home and monkeypatch ssh parser for ssh config testing #523

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 4, 2023

Part of #516

@unkcpz unkcpz requested review from danielhollas and yakutovicha and removed request for danielhollas October 4, 2023 15:55
@unkcpz unkcpz changed the title Use tmp_path for ssh config testing Use mock home and monkeypatch ssh parser for ssh config testing Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a1b5134) 79.39% compared to head (936de4f) 79.97%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
+ Coverage   79.39%   79.97%   +0.57%     
==========================================
  Files          27       27              
  Lines        3849     3830      -19     
==========================================
+ Hits         3056     3063       +7     
+ Misses        793      767      -26     
Flag Coverage Δ
python-3.10 79.97% <92.85%> (+0.57%) ⬆️
python-3.8 80.01% <92.85%> (+0.57%) ⬆️
python-3.9 80.01% <92.85%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aiidalab_widgets_base/computational_resources.py 69.84% <100.00%> (-0.18%) ⬇️
tests/test_computational_resources.py 100.00% <100.00%> (ø)
tests/test_structures.py 100.00% <100.00%> (ø)
aiidalab_widgets_base/structures.py 77.99% <83.33%> (+3.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yakutovicha yakutovicha merged commit 6003129 into master Oct 4, 2023
14 of 15 checks passed
@yakutovicha yakutovicha deleted the fix/516-2/ssh-tmp-path branch October 4, 2023 17:17
unkcpz added a commit to unkcpz/aiidalab-widgets-base that referenced this pull request Nov 16, 2023
* Bump awb to 2.1.0a0

* Move pseudo installer to common to avoid app load and load_profile in CLI commands for QE and pseudos installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants