Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of deprecation warnings in computational_resources.py #508

Conversation

danielhollas
Copy link
Contributor

pytest test/test_computational_resources.py would generate 7 deprecation warnings coming from ipywidgets and traitlets.

Step towards fixing #490

pytest test/test_computational_resources.py
would generate 7 deprecation warnings coming
from ipywidgets and traitlets.
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (5038966) 79.42% compared to head (1c41819) 79.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   79.42%   79.46%   +0.03%     
==========================================
  Files          27       27              
  Lines        3757     3759       +2     
==========================================
+ Hits         2984     2987       +3     
+ Misses        773      772       -1     
Flag Coverage Δ
python-3.10 79.46% <100.00%> (+0.03%) ⬆️
python-3.8 79.49% <100.00%> (+0.03%) ⬆️
python-3.9 79.49% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiidalab_widgets_base/databases.py 94.11% <ø> (+0.65%) ⬆️
aiidalab_widgets_base/computational_resources.py 70.66% <100.00%> (+0.10%) ⬆️
tests/test_computational_resources.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas marked this pull request as ready for review September 3, 2023 21:16
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielhollas danielhollas merged commit aec8f87 into aiidalab:master Sep 6, 2023
8 checks passed
@danielhollas danielhollas deleted the fix/deprecation-warnings-comp-resources branch September 6, 2023 08:39
@danielhollas danielhollas mentioned this pull request Sep 6, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants