Bump scikit-learn #498
Merged
Bump scikit-learn #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scikit-learn build for version 0.24 started failing due to new version of Cython so we bump the version to 1.0. Per docs, this version does not bring any breaking changes. https://scikit-learn.org/1.0/auto_examples/release_highlights/plot_release_highlights_1_0_0.html We also only use the sklearn.PCA in SMILES widget, I've verified that it still works and checked the release notes that there are not API changes to this method. https://scikit-learn.org/1.0/whats_new/v1.0.html#changes-1-0
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
=======================================
Coverage 79.63% 79.63%
=======================================
Files 27 27
Lines 3752 3752
=======================================
Hits 2988 2988
Misses 764 764
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@unkcpz thanks! I'll merge this to unblock the other PRs. |
|
We should have probably put |
|
I've done this on purpose to make sure things work for now. As explained in the OP I want to get rid of it altogether soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scikit-learn build for version 0.24 started failing due to new version of Cython so we bump the version to 1.0. Per docs, this version does not bring any breaking changes. https://scikit-learn.org/1.0/auto_examples/release_highlights/plot_release_highlights_1_0_0.html
We also only use the sklearn.PCA in SMILES widget, I've verified that it still works and checked the release notes that there are not API changes to this method.
https://scikit-learn.org/1.0/whats_new/v1.0.html#changes-1-0
In the near future I'd like to get rid of scikit-learn altogether since it is a very heavy dependency and we only use it for PCA to reorient the molecules generated from SMILES by RDkit. I have a suspicion that this step is not really needed, and if it is, we can simply vendor the PCA function.