Test and update the wizard module

[yakutovicha]

fixes #461
fixes #343

[codecov]

Codecov Report

Patch coverage: 97.26% and project coverage change: +1.90 🎉

Comparison is base (3b7aff7) 77.41% compared to head (35756f1) 79.32%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   77.41%   79.32%   +1.90%     
==========================================
  Files          26       27       +1     
  Lines        3626     3685      +59     
==========================================
+ Hits         2807     2923     +116     
+ Misses        819      762      -57     

Flag	Coverage Δ
python-3.10	79.32% <97.26%> (+1.90%)	⬆️
python-3.8	79.35% <97.26%> (+1.88%)	⬆️
python-3.9	79.35% <97.26%> (+1.88%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
tests/test_wizard.py	96.42% <96.42%> (ø)
aiidalab_widgets_base/wizard.py	92.45% <100.00%> (+57.50%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[unkcpz]

@yakutovicha thanks! only some minor requests.

BTW, Is that possible to address #343 here?
The issue seems caused from when the accordion widget has all steps folder, the selected_index can be None, when status of a step widget is reset, it triggers widget update and hint at the exception.

    # last step success and reset (To mimic new workflow in QeApp)
    assert s1.state == s1.State.SUCCESS
    widget.accordion.selected_index = None
    s1.state = s1.State.INIT # this will trigger the update method and hint the problem

[unkcpz]

Suggested change

	if not testing: # pytest is hanging if we start a thread
	threading.Thread(target=spinner_thread).start()
	self.spinner_thread = threading.Thread(target=spinner_thread).start()

The thread can be stop and joined in the test explicitly. It is also good to leave a handler attribute to get control of inner thread.

[yakutovicha]

How would you do that? I tried the following, but it didn't work:

self.spinner_thread._stop()

The only working option I could think of is do something like so:

        self._run_update_thread = True
        def spinner_thread():
            while self._run_update_thread:
                time.sleep(0.1)
                self._update_titles()

        threading.Thread(target=spinner_thread).start()

[unkcpz]

Did you try self.spinner_thread.join() this will wait for the thread to stop and finish. We did it here https://github.com/aiidalab/aiidalab/blob/50498b08ea77937cb8af0e8d753446dd17b6d637/tests/test_appclass.py#L87-L104
we can try together.

[yakutovicha]

Did you try self.spinner_thread.join() this will wait for the thread to stop and finish. We did it here https://github.com/aiidalab/aiidalab/blob/50498b08ea77937cb8af0e8d753446dd17b6d637/tests/test_appclass.py#L87-L104 we can try together.

The problem is that the current loop is infinite:

while True:
    ....

So there is no reason for it to stop. And calling _stop() didn't stop it, it just excepted.

[yakutovicha]

fixed in 35756f1

[unkcpz]

Thanks Looks all good to me.