Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pymysql version restriction to ~=0.9 #465

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

yakutovicha
Copy link
Member

@yakutovicha yakutovicha commented Mar 22, 2023

fixes #463

@yakutovicha yakutovicha requested a review from unkcpz March 22, 2023 13:21
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (85f811e) 72.75% compared to head (f2c0588) 72.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files          23       23           
  Lines        3516     3516           
=======================================
  Hits         2558     2558           
  Misses        958      958           
Flag Coverage Δ
python-3.10 72.75% <ø> (ø)
python-3.8 72.80% <ø> (ø)
python-3.9 72.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yakutovicha yakutovicha merged commit 0690086 into master Mar 22, 2023
@yakutovicha yakutovicha deleted the fix/lower-pymysql-minimal-version branch March 22, 2023 13:41
unkcpz pushed a commit to unkcpz/aiidalab-widgets-base that referenced this pull request Nov 16, 2023
- add get and set_setting_parameters for advanced settings.
- move the logic of getting overrides of base, scf, bands and scf to the individual plugin.
- link the spin_type and electronic_type to the advanced setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pymysql version not compatible
2 participants