Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/configure tabs #429

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Fix/configure tabs #429

merged 4 commits into from
Feb 9, 2023

Conversation

AndresOrtegaGuerrero
Copy link
Member

fixes #425

yakutovicha
yakutovicha reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AndresOrtegaGuerrero. One minor thing.

aiidalab_widgets_base/viewers.py Outdated Show resolved Hide resolved
@AndresOrtegaGuerrero @yakutovicha
Update aiidalab_widgets_base/viewers.py
bcf1c4e 
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
@yakutovicha yakutovicha self-requested a review February 9, 2023 14:56
yakutovicha
yakutovicha approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AndresOrtegaGuerrero!

@yakutovicha yakutovicha merged commit f9130e9 into aiidalab:master Feb 9, 2023
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the fix/configure_tabs branch February 10, 2023 08:26
unkcpz pushed a commit to unkcpz/aiidalab-widgets-base that referenced this pull request Nov 16, 2023
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (aiidalab#429)
1540ebf 
updates:
- [github.com/jumanjihouse/pre-commit-hook-yamlfmt: 0.2.2 → 0.2.3](jumanjihouse/pre-commit-hook-yamlfmt@0.2.2...0.2.3)
- [github.com/sirosen/check-jsonschema: 0.22.0 → 0.23.2](python-jsonschema/check-jsonschema@0.22.0...0.23.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhollas danielhollas danielhollas left review comments

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configuration_tabs option of StructureDataViewer is broken
3 participants
@AndresOrtegaGuerrero @danielhollas @yakutovicha