Install firefox/geckodriver in GH workflow for test

[unkcpz]

No description provided.

[danielhollas]

I am confused, the tests seem to be duplicated? e.g. running on both pull_reqest and push.

[unkcpz]

I am confused, the tests seem to be duplicated? e.g. running on both pull_reqest and push.

That's because I make the PR from this repo directly. Other repositories are the same has actions on pull request and push.

[danielhollas]

Fair enough. Can you explain a bit the changes here? What are they supposed to solve?
Some tests seems to be still failing.

[unkcpz]

The test failed since somehow the github server doesn't install firefox by default but only the chrome engine. I think the change happened last week both QeApp and AWB encounter the same issue. However I cannot find the change log from web.
Install the geckodriver and firefox, and then specify the path to the firefox engine in selenium test solve the issue

Some tests seems to be still failing.

The test through selenium is still not very robust, it depends on whether the page is successfully loaded, where I set sleep time to wait to load but not always reach the end. Probably there are a pattern we can use to sure the page is loaded. Such like.

try:
    element_present = EC.presence_of_element_located((By.ID, 'element_id'))
    WebDriverWait(driver, timeout).until(element_present)
except TimeoutException:
    print "Timed out waiting for page to load"

[danielhollas]

The test through selenium is still not very robust, it depends on whether the page is successfully loaded, where I set sleep time to wait to load but not always reach the end. Probably there are a pattern we can use to sure the page is loaded. Such like.

That's an interesting pattern, thanks! Are you planning to implement it as part of this PR? Would be good to have the tests passing again.

I think it would be good to also pin the setuptools to get rid of the readthedocs failure. I guess it will take us some time to migrate to flit+pyproject.toml so we should fix it in the meantime. https://github.com/aiidateam/aiida-core/pull/5782/files

[unkcpz]

That's an interesting pattern, thanks! Are you planning to implement it as part of this PR? Would be good to have the tests passing again.

I simply increase the load time to workaround 😁, open issue #398 to be addressed soon.

I think it would be good to also pin the setuptools to get rid of the readthedocs failure. I guess it will take us some time to migrate to flit+pyproject.toml so we should fix it in the meantime

Yes, I agree. The pyproject.toml is added and pinning the setuptools version to 65.5.0. It seems the issue is fixed from 65.6.3, will try.

EDIT: the problem is from requests_cache required by eln notebook not installed, don't know why the previous version is fine. But it should work now after add it. doc build conf.py import the package which is not necessary.

[danielhollas]

I think it would make more sense for this to be an environment variable.
Having it here is a bit misleading, since if you were to set this to two versions, the matrix would be broken, since these versions are only valid for browser==Firefox, not browser==Chrome

[unkcpz]

Fair, thanks a lot! I add the check for the matrix and add a comment.

[danielhollas]

All tests passing! 🎉 Thanks so much @unkcpz