StructureUploadWidget: Multiple structures from a single file #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, we do not allow multiple structures in a single file that is being uploaded. Here I introduce an option to allow this and returning the TrajectoryData node in such cases.
danielhollas
added a commit
to ispg-group/aiidalab-ispg
that referenced
this pull request
Sep 7, 2022
Depends on aiidalab/aiidalab-widgets-base#353 Closes #29
yakutovicha
requested changes
Sep 7, 2022
|
@yakutovicha @csadorf I was wondering if I could be added as a collaborator on this repo? It would be nice to be able to add labels and request reviewers (less work for you 😊) |
danielhollas
added a commit
to ispg-group/aiidalab-ispg
that referenced
this pull request
Sep 7, 2022
Depends on aiidalab/aiidalab-widgets-base#353 Closes #29
yakutovicha
approved these changes
Sep 7, 2022
danielhollas
added a commit
to ispg-group/aiidalab-ispg
that referenced
this pull request
Sep 13, 2022
Depends on aiidalab/aiidalab-widgets-base#353 * Setup dependency on aiidalab-widgets-base 1.4.0 * Disable test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we do not allow multiple structures in a single file that is being uploaded.
Here I introduce an option to allow this and returning a TrajectoryData node in such cases.
Extracted from #332.
CC @yakutovicha