Fix issue workchain viewer not designated for workchains except QeAppWorkchain #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
fix/334/workchain
branch
from
b4e4818
to
867b3ad
Compare
unkcpz
force-pushed
the
fix/334/workchain
branch
from
a0e260a
to
9a6a8ff
Compare
unkcpz
changed the title
Don't worry 😄, I'll ask @superstar54 to give it a test after I revert the wrong change. Thanks a lot for reviewing. |
|
@superstar54, can you give a look at this? Thanks! |
|
I tested the example reported in #344. No error anymore. 👍 |
|
Thanks @superstar54. Can you approve it then? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with aiidalab/aiidalab-widgets-base#430 should fix #344fixes #344
The
register_viewer_widgetdecorator registers the viewer by class and the new viewer for QeAppWorkchain specifically also become the viewer of other WorkChain. It will raise theKeyErrorand raised which is not expected.Instead of raising the exception, nothing is returned. This is a workaround since ideally if there is no new specific viewer defined for a specific work chain, it needs to fall back to the native one of AWB. As tried in aiidalab/aiidalab-widgets-base#430