Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the band structure plotting #104

Closed
3 of 4 tasks
mkotiuga opened this issue Jul 27, 2021 · 5 comments
Closed
3 of 4 tasks

Improve the band structure plotting #104

mkotiuga opened this issue Jul 27, 2021 · 5 comments

Comments

@mkotiuga
Copy link
Member

mkotiuga commented Jul 27, 2021

Some ideas to improve the band structure plotting:

  • (1) The Fermi energy needs to, at least be indicated, or, even better, be set to 0
  • (2) Y-label changed from 'dispersion' to 'Energy', 'E', or 'electronic dispersion' (there are other dispersions that are commonly plotted in a similar fashion aside from electronic energy dispersion - mostly phonon dispersions...). If the Fermi energy is set to be 0, then the label should be something like 'E-E_F'
  • (3) A smaller window would be better, maybe E_F +/- 5 eV or so? Anyway, the really low bands are often just not physical, and the high bands are really sensitive to the energy cutoffs used and can show funny unphysical results as well.
  • (4) For ferromagnetic calculations, a way to distinguish between the spin-up and spin-down bands. ( you can compare the results of pk 630 to https://materialsproject.org/materials/mp-13/)
@mkotiuga mkotiuga added the enhancement New feature or request label Jul 27, 2021
@mbercx mbercx self-assigned this Aug 10, 2021
@csadorf csadorf self-assigned this Aug 24, 2021
@csadorf
Copy link
Member

csadorf commented Aug 24, 2021

I will try to take care of re-introducing Dou's widget.

@csadorf csadorf removed their assignment Oct 4, 2021
@csadorf csadorf changed the title Band structure plotting Improve the band structure plotting Oct 4, 2021
@csadorf
Copy link
Member

csadorf commented Oct 4, 2021

I will try to take care of re-introducing Dou's widget.

Done in e5b6798 and released in https://github.com/aiidalab/aiidalab-qe/releases/tag/v21.08.0b3 .

@csadorf
Copy link
Member

csadorf commented Nov 3, 2021

@dou-du Could you comment on this issue, please?

@mbercx mbercx added this to the 2021-11 milestone Nov 3, 2021
@unkcpz unkcpz self-assigned this Nov 29, 2021
@csadorf csadorf modified the milestones: 2021-11, 2021-12 Nov 29, 2021
@unkcpz
Copy link
Member

unkcpz commented Nov 29, 2021

I am pretty sure the latest bandplot widget address the first three issues. I am checking the fourth, running calculation on Fe and see the electronic structure. I think the bandplot widget can distinguish the up and down spin, only need to dump the corresponding outputs and feed them to the widget.

The update to new widget is included in and closed by #159 too.

@unkcpz
Copy link
Member

unkcpz commented May 6, 2022

The last (4) point is brought up in osscar-org/widget-bandsplot#8. I will close this issue and open a specific one #229.

@unkcpz unkcpz closed this as completed May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants