Skip to content

Commit

Permalink
Hardcode the library version when installing pseudo family (#425)
Browse files Browse the repository at this point in the history
There is an issue that when the aiida-pseudo update to have the latest version of library, such as from `v1,2` to `v1.3`, since in the QeApp we hardcode the library for workchain protocol, the install command in `sssp.py` will fail because it trys to install the latest version which is `v1.3` but it not compatible with the validate version that is `v1.2`.

In this commit, we also hardcode the version to the install command to make sure when a new version is available in aiida-pseudo, it will still install the correct version.
  • Loading branch information
superstar54 committed Jun 22, 2023
1 parent d210b45 commit 92f567c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions aiidalab_qe/app/sssp.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ def run_(*args, **kwargs):
p_func,
"-p",
p_type,
"-v",
"1.2",
]
elif pseudo.startswith("PseudoDojo"):
p_family, p_version, p_func, p_rel, p_type, p_format = pseudo.split("/")
Expand All @@ -78,6 +80,8 @@ def run_(*args, **kwargs):
p_type,
"-f",
p_format,
"-v",
"0.4",
]
run_(cmds)

Expand Down

0 comments on commit 92f567c

Please sign in to comment.