Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/artifact-upload to v4 #423

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Bump actions/artifact-upload to v4 #423

merged 3 commits into from
Dec 18, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 18, 2023

This is a revert amendment of #419 which merged improperly with test commints.

  • The changes should significantly speed up artifact upload, see https://github.com/actions/upload-artifact#v4---whats-new
  • Also include the updates of action/checkout action to v4
  • include fix the python version of running environment to 3.11.
  • include the changes of removing paths change detection in docker.yml

@unkcpz
Copy link
Member Author

unkcpz commented Dec 18, 2023

I am ordering a request for the firewall rule in PSI, hope it will work. I'll keep this PR open for the test.
Will also look into the timeout of the action.

@danielhollas
Copy link
Contributor

Thanks @unkcpz. If the firewall rule does not fix it, we can use V3 action for arm and v4 for amd, and then focus on removing the artifacts entirely.

@unkcpz
Copy link
Member Author

unkcpz commented Dec 18, 2023

If the firewall rule does not fix it, we can use V3 action for arm and v4 for amd, and then focus on removing the artifacts entirely.

Sadly no, from IT he said the TCP ports 80/443 is allowed by default, therefore no specific firewall rule is needed.

@unkcpz
Copy link
Member Author

unkcpz commented Dec 18, 2023

I test it with aiida-core image which is a smaller one, all good. I think it is the problem of the action it self. See aiidateam/aiida-core#6228

@unkcpz
Copy link
Member Author

unkcpz commented Dec 18, 2023

I remove the compression setting and all works. There are two possibilities, 1) the artifact is too large 2) no compression causes the problem.

@unkcpz
Copy link
Member Author

unkcpz commented Dec 18, 2023

then focus on removing the artifacts entirely.

I'll find time work on this this week anyway.

@danielhollas
Copy link
Contributor

That's a great find, thanks! The default compression level is 6, so you can try something between 1-5 to see if it works and is faster. In any case, v4 is much faster even with default compression level so this is worth merging anyway.

@unkcpz unkcpz merged commit 8b4faa7 into main Dec 18, 2023
25 checks passed
@unkcpz unkcpz deleted the bump-artifact-upload branch December 18, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants