We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When fetching the contacts between 'chr1' 'chrM', it gives the same result as 'chrM' 'chr1' without any notice to the user.
To Reproduce
import numpy as np import hicstraw hic_file = 'ENCFF080DPJ.hic' chrom1 = 'chr1' chrom2 = 'chr2' result = hicstraw.straw('observed', 'NONE', hic_file, chrom1, chrom2, 'BP', 1000000) for i in range(10): print("{0}\t{1}\t{2}".format(result[i].binX, result[i].binY, result[i].counts)) result = hicstraw.straw('observed', 'NONE', hic_file, chrom2, chrom1, 'BP', 1000000) for i in range(10): print("{0}\t{1}\t{2}".format(result[i].binX, result[i].binY, result[i].counts))
Expected behavior I would expect to have the same result but with column 1 and 2 shifted. I got exactly the same result.
The problem is that the chromosomes are flipped here:
straw/pybind11_python/src/straw.cpp
Lines 1222 to 1227 in 2525edc
Lines 1368 to 1374 in 2525edc
Line 1430 in 2525edc
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
When fetching the contacts between 'chr1' 'chrM', it gives the same result as 'chrM' 'chr1' without any notice to the user.
To Reproduce
Expected behavior
I would expect to have the same result but with column 1 and 2 shifted.
I got exactly the same result.
The problem is that the chromosomes are flipped here:
straw/pybind11_python/src/straw.cpp
Lines 1222 to 1227 in 2525edc
Therefore, the results are not flipped back in:
straw/pybind11_python/src/straw.cpp
Lines 1368 to 1374 in 2525edc
and the matrix is not transposed in:
straw/pybind11_python/src/straw.cpp
Line 1430 in 2525edc
The text was updated successfully, but these errors were encountered: