DDG4Python: only build things if python and pyroot are found #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2020
andresailer
force-pushed
the
fixDDPython
branch
from
0f3ee43 to
e305999
Compare
andresailer
force-pushed
the
fixDDPython
branch
from
e305999 to
a9a843f
Compare
|
Merging now so maybe the lcg nightly builds can run over the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (at least part of) #625
While the add_dictionary command was called, the rootcling command behind it was never executed because the library that used the cxx was not created when PyROOT is not found, still the install command for the pcm file was there leading to the error described in #625
@MarkusFrankATcernch I am not sure if having the pcms without the libraries makes sense so I put it all in one if, alternatively we could force the creation of the cxx and pcm file even if they are not needed.
BEGINRELEASENOTES
ENDRELEASENOTES