Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the CellIDEncoding strings in the metadata Frame #1140

Merged

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

ENDRELEASENOTES

If the whole LazyEncodingExtraction is too much of a premature optimization I can also take it out again and just put the interesting two lines into saveCollection directly.

I still have to think about an easy test for this (and where to put it).

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Test Results

       6 files         6 suites   6h 41m 56s ⏱️
   353 tests    353 ✔️ 0 💤 0
1 049 runs  1 049 ✔️ 0 💤 0

Results for commit 25f4fb5.

@MarkusFrankATcernch
Copy link
Contributor

MarkusFrankATcernch commented Jul 4, 2023

@tmadlener
If we really want to save extended metadata in the files, then these wild ad-hoc approaches at some point will lead
to chaotic data addings, where at the end nobody will know anymore how legally the data part should look like.
We will need some glossary about the keywords and the formatting of the data part.

@tmadlener
Copy link
Contributor Author

Yes, this convention needs to be properly documented in podio (at least). Ideally, we "hide" as much as possible of this behind some utility functionality, but we are not there yet. The problem is that the cellIDs need to be there otherwise many things will not work downstream, so for now I have to hardcode the convention in here to not block other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants