Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make podio type name calls future string_view proof #1124

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jun 2, 2023

BEGINRELEASENOTES

  • DDDigi: Make the get{Value,}TypeName calls work with the upcoming switch to std::string_view return types in podio.

ENDRELEASENOTES

AIDASoft/podio#402 switches these to constexpr static std::string_views. Since these are viewing string literals string_view::data is guaranteed to be null terminated (in this case). std::string::data is also guaranteed to be null terminated since c++11 (it has to be equivalent to c_str).

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Test Results

       8 files         8 suites   5h 24m 6s ⏱️
   347 tests    347 ✔️ 0 💤 0
1 369 runs  1 369 ✔️ 0 💤 0

Results for commit 86c4a27.

@andresailer andresailer merged commit a87228b into AIDASoft:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants