Make podio type name calls future string_view proof #1124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
get{Value,}TypeName
calls work with the upcoming switch tostd::string_view
return types in podio.ENDRELEASENOTES
AIDASoft/podio#402 switches these to
constexpr static std::string_views
. Since these are viewing string literalsstring_view::data
is guaranteed to be null terminated (in this case).std::string::data
is also guaranteed to be null terminated since c++11 (it has to be equivalent toc_str
).