Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MiniTel example to serve as example for issue #1098

Merged
merged 4 commits into from
May 30, 2023

Conversation

MarkusFrankATcernch
Copy link
Contributor

BEGINRELEASENOTES

ENDRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor Author

@andresailer In test job https://github.com/AIDASoft/DD4hep/actions/runs/4797217643/jobs/8535995123
There seems to be a mismatch in the Geant4 version. Is this true?

@andresailer
Copy link
Member

@MarkusFrankATcernch I think the problem is rather missing geant4 include dirs in ROOT_INCLUDE_PATH
I wanted to debug this soon. And the DDCad problem is hopefully solved with #1099

@andresailer
Copy link
Member

Actually the Geant4 include path given to the command in the test is wrong, there is a superfluous lib64
-I/cvmfs/sw.hsf.org/spackages7/geant4/11.1.1/x86_64-centos7-gcc11.2.0-opt/jlctn/lib64/include/Geant4,

@andresailer
Copy link
Member

The location of the Geant4Config.cmake etc. changed in 11.1.1? now it is in lib64/cmake/Geant4, instead of lib64/Geant4-11.1.0, and we derive the wrong location of the include directories from that.

@andresailer
Copy link
Member

I hope all errors in the key4hep stack are now fixed in #1099

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

Test Results

       6 files         6 suites   5h 30m 42s ⏱️
   345 tests    345 ✔️ 0 💤 0
1 025 runs  1 025 ✔️ 0 💤 0

Results for commit 0dc88fb.

♻️ This comment has been updated with latest results.

@MarkusFrankATcernch MarkusFrankATcernch merged commit 3c5cb7e into AIDASoft:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants