-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nudge-to-fine workflow not updating SSTs #1037
Comments
@spencerkclark Does the |
It normally will act throughout the run; basically what it does is add an offset to the climatological SST the model is relaxed to by default.
Exactly, if the surface temperature is set through the wrapper, indeed the |
My suspicion here was correct. I have verified this with a test in the Python wrapper. Similar to the surface radiative fluxes, I think we will need to use a Edit: actually in this case I think a namelist flag alone approach would do (i.e. just have a flag to restore the fortran behavior prior to ai2cm/fv3gfs-fortran#93 if we are prescribing SSTs). |
This notebook illustrates that when completing a nudged run with the namelist flag added in ai2cm/fv3gfs-fortran#173, that the SSTs are indeed modified when compared with a case without the namelist flag active. |
So what were the differences in the notebook above from if they weren't from the nudging runs setting the SSTs? |
It's a little subtle. If we do not set the SST via the wrapper, but use |
Thanks that makes sense. |
#1101 adds the fix required to fv3net to take advantage of this. Note per discussion with @mcgibbon I have modified the relevant namelist parameter in the fortran model. It is now called |
This PR restores the logic needed to update the sea surface temperature via the Python wrapper. Resolves #1037
The nudging runs are supposed to update coarse-model SSTs with the reference state but the N2F workflow in the sklearn_runfile is missing the actual state update call after it gets the reference SSTs:
https://github.com/VulcanClimateModeling/fv3net/blob/f646892b3c7fc752efadae9d70df94a45e512489/workflows/prognostic_c48_run/runtime/steppers/nudging.py#L89
The text was updated successfully, but these errors were encountered: