{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":232625494,"defaultBranch":"master","name":"fv3gfs-fortran","ownerLogin":"ai2cm","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-01-08T17:56:16.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/55798839?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1698960322.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"b5f9633d1cc2195ec6e8afe2fccdc3bc1cb74e4e","ref":"refs/heads/dependabot/pip/FV3/wrapper/tests/pytest/pip-23.3","pushedAt":"2023-11-02T21:25:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump pip from 21.1 to 23.3 in /FV3/wrapper/tests/pytest\n\nBumps [pip](https://github.com/pypa/pip) from 21.1 to 23.3.\n- [Changelog](https://github.com/pypa/pip/blob/main/NEWS.rst)\n- [Commits](https://github.com/pypa/pip/compare/21.1...23.3)\n\n---\nupdated-dependencies:\n- dependency-name: pip\n dependency-type: direct:production\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump pip from 21.1 to 23.3 in /FV3/wrapper/tests/pytest"}},{"before":"7f1456981d66fdc68bee775e16b37afad1e65a2e","after":null,"ref":"refs/heads/surface-type-fractions","pushedAt":"2023-10-16T16:17:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"}},{"before":"57fc22b139bf0d0bd253c477196b57d5347ab1ae","after":"e3c522d285b2c9dac925f21e8c3d1f36df9f2dda","ref":"refs/heads/master","pushedAt":"2023-10-16T16:17:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Add surface type fraction diagnostics (#377)\n\nThis PR adds diagnostics-manager-controlled surface-type-fraction diagnostics for the `ocean_fraction`, `land_fraction`, and `sea_ice_fraction`. These are all added as part of the `gfs_sfc` diagnostics module, similar to the `slmsksfc` diagnostic containing the integer-encoded surface type. As stated in #371, the advantage of these diagnostics is that they can be sensible time-and-area-averaged, so they retain their value upon standard time-averaging, coarse-graining, and conservative regridding approaches. \r\n\r\n[This notebook](https://github.com/ai2cm/explore/blob/master/spencerc/2023-08-21-surface-type-fraction/2023-08-21-test-surface-type-fraction-diagnostics.ipynb) shows that these diagnostics are working as expected.\r\n\r\nNote that it is theoretically possible to run FV3GFS with fractional land (this PR assumes one is always running in the mode of one grid cell, one surface type). Since we have not explored running in that mode yet, we have elected to omit trying to handle that case in this PR (it would make things more complicated).\r\n\r\nResolves #371.","shortMessageHtmlLink":"Add surface type fraction diagnostics (#377)"}},{"before":"56a9bab2700d3309b7afeb4b2f7cd46ce021aade","after":"7f1456981d66fdc68bee775e16b37afad1e65a2e","ref":"refs/heads/surface-type-fractions","pushedAt":"2023-10-03T13:45:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Fix tests after merging and neglecting to re-configure","shortMessageHtmlLink":"Fix tests after merging and neglecting to re-configure"}},{"before":"76c947f2fac68526e2366fcbc63ffd2b7adfdf11","after":"56a9bab2700d3309b7afeb4b2f7cd46ce021aade","ref":"refs/heads/surface-type-fractions","pushedAt":"2023-10-02T22:41:45.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Merge branch 'master' into surface-type-fractions","shortMessageHtmlLink":"Merge branch 'master' into surface-type-fractions"}},{"before":"3117b5eae0a4a32aa8d92aacd481f269803774d2","after":"76c947f2fac68526e2366fcbc63ffd2b7adfdf11","ref":"refs/heads/surface-type-fractions","pushedAt":"2023-10-02T22:09:54.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Merge branch 'master' into surface-type-fractions","shortMessageHtmlLink":"Merge branch 'master' into surface-type-fractions"}},{"before":"31475dae30a3afdd3cff12a7165a49b6c55ff37b","after":null,"ref":"refs/heads/fix-checksum-restart-files-and-diagnostics","pushedAt":"2023-10-02T16:11:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"}},{"before":"70ae00da6fde760ddc372c504d62df81246e19d1","after":"57fc22b139bf0d0bd253c477196b57d5347ab1ae","ref":"refs/heads/master","pushedAt":"2023-10-02T16:11:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Fix typo in test_regression.py (#383)\n\nI noticed this when looking over this file earlier, and it would be good to correct for maximum test coverage. This was introduced in #379, so it has not been present for long.","shortMessageHtmlLink":"Fix typo in test_regression.py (#383)"}},{"before":null,"after":"31475dae30a3afdd3cff12a7165a49b6c55ff37b","ref":"refs/heads/fix-checksum-restart-files-and-diagnostics","pushedAt":"2023-09-21T00:44:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Fix typo in test_regression.py\n\nI noticed this when looking over this file earlier, and it would be good to correct for maximum test coverage.","shortMessageHtmlLink":"Fix typo in test_regression.py"}},{"before":"9c74258d137c90e0c3d5d9f15c62c1cd3d48cb71","after":null,"ref":"refs/heads/fix-tests","pushedAt":"2023-09-07T21:34:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"}},{"before":"adafc50da9ec8721c44894594c405942c2bd4f1d","after":"70ae00da6fde760ddc372c504d62df81246e19d1","ref":"refs/heads/master","pushedAt":"2023-09-07T21:34:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Fix test skipping logic in debug-mode emulation tests (#382)\n\nThis PR fixes errors in test skipping logic introduced in #379 (see [this CI run](https://app.circleci.com/pipelines/github/ai2cm/fv3gfs-fortran/2682/workflows/e71d0119-0c60-44c7-bf4f-d97f10ccbb0b/jobs/5541)). In that PR these particular tests were configured only to be attempted to be run upon merges to master, because they would be skipped anyway. \r\n\r\nThis PR also now ensures that we at least attempt to run the emulation tests in debug mode in CI when the developer requests to, since it will exercise the skipping logic before merging to master (upon which all pure fortran tests are attempted to be run in both repro and debug mode).\r\n\r\n[This CI job](https://app.circleci.com/pipelines/github/ai2cm/fv3gfs-fortran/2688/workflows/0c3ca3a2-3b4d-46d6-8cca-a65e1b9a5a0f/jobs/5557) confirms that this PR worked as intended.","shortMessageHtmlLink":"Fix test skipping logic in debug-mode emulation tests (#382)"}},{"before":"24c2e0e0220d580a3034420f5c7115ed968516d6","after":"9c74258d137c90e0c3d5d9f15c62c1cd3d48cb71","ref":"refs/heads/fix-tests","pushedAt":"2023-09-07T20:46:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Fix test skipping syntax; hook into CI","shortMessageHtmlLink":"Fix test skipping syntax; hook into CI"}},{"before":"52ce0d9dc57fb87527945742b164946517e9ea63","after":"24c2e0e0220d580a3034420f5c7115ed968516d6","ref":"refs/heads/fix-tests","pushedAt":"2023-09-07T20:44:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Fix test skipping syntax; hook into CI","shortMessageHtmlLink":"Fix test skipping syntax; hook into CI"}},{"before":"0caf50df96255159c1707bb5c89774226a89ca52","after":"52ce0d9dc57fb87527945742b164946517e9ea63","ref":"refs/heads/fix-tests","pushedAt":"2023-09-07T20:34:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Hook debug mode tests into the Launch emulation tests CI workflow","shortMessageHtmlLink":"Hook debug mode tests into the Launch emulation tests CI workflow"}},{"before":"dd22953ba84429e3122a30f6ff9af7723d55e353","after":"0caf50df96255159c1707bb5c89774226a89ca52","ref":"refs/heads/fix-tests","pushedAt":"2023-09-07T20:32:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Hook debug mode tests into the Launch emulation tests CI workflow","shortMessageHtmlLink":"Hook debug mode tests into the Launch emulation tests CI workflow"}},{"before":null,"after":"dd22953ba84429e3122a30f6ff9af7723d55e353","ref":"refs/heads/fix-tests","pushedAt":"2023-09-07T20:28:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Fix test skipping syntax","shortMessageHtmlLink":"Fix test skipping syntax"}},{"before":"8c2831b69c8897fe95dabcc49f5ac1c2068b6bb6","after":null,"ref":"refs/heads/nix-debug-mode","pushedAt":"2023-09-07T18:56:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"}},{"before":"b3793303df9800de341a3f8e8b234c6f4dc2b7a1","after":"adafc50da9ec8721c44894594c405942c2bd4f1d","ref":"refs/heads/master","pushedAt":"2023-09-07T18:56:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Run all tests in the `nix-shell`; eliminate docker infrastructure (#379)\n\nThis PR refactors the build infrastructure in this repo to eliminate the need for the Docker component. All development and testing is now done in the `nix` shell. This should be a quality of life improvement for anyone developing the fortran model, as it no longer requires maintaining checksums in two separate build environments.\r\n\r\nIn so doing it introduces the following changes:\r\n- New `make` rules are provided for compiling the model in different modes:\r\n - `build` -- build executables in `repro` (our production mode) and `debug` mode.\r\n - `build_repro` -- build only the `repro` mode executable.\r\n - `build_debug` -- build only the `debug` mode executable.\r\n- Tests are run with each of the executables available in the local `bin` directory, and are tagged with the associated compile mode. \r\n- An option, `check_layout_invariance`, is provided to trigger regression tests be run with a 1x2 domain decomposition instead of a 1x1 domain decomposition to check invariance to the domain decomposition layout; this is used for the all the coarse-graining regression tests and replaces the previous `test_run_reproduces_across_layouts` test that would run in the docker image.\r\n- `debug`-mode and `repro`-mode simulations produce different answers, which is something we noticed in #364 when upgrading compiler versions as well, and so require different reference checksums.\r\n\r\nIn working on this PR, we ran the fortran model in `debug` mode in more contexts than we had previously, some of which turned up errors, which we currently work around by using `pytest.skip` (something we had implicitly already been doing before):\r\n- #365\r\n- #381 \r\n\r\nWorking on this PR also brought my attention to the fact that `pytest`'s `tmpdir` fixture does not automatically get cleaned up after each test; `pytest` versions older than 7.3.0 keep around directories from the last three runs of `pytest`, which fill up disk space quickly since running these tests requires creating 10's of run directories, each with their own initial conditions and input files (#380). For the time being I manually clean up these run directories after successful tests.\r\n\r\nResolves #340.","shortMessageHtmlLink":"Run all tests in the nix-shell; eliminate docker infrastructure (#379)"}},{"before":"0637993388638133c775c5d9be9d7fd6d89acfca","after":"8c2831b69c8897fe95dabcc49f5ac1c2068b6bb6","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-31T20:36:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update README per review comments","shortMessageHtmlLink":"Update README per review comments"}},{"before":"50de16b598067c98fc7fd044b7b724ae4a4bdc08","after":"0637993388638133c775c5d9be9d7fd6d89acfca","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-31T20:34:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update README per review comments","shortMessageHtmlLink":"Update README per review comments"}},{"before":"1e619a4013d56d15c55e65c26a3af7aa3171032e","after":"50de16b598067c98fc7fd044b7b724ae4a4bdc08","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-30T17:57:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update relevant README files","shortMessageHtmlLink":"Update relevant README files"}},{"before":"cb4185c18a3673ef843b15ab6b8af162788f0cec","after":"1e619a4013d56d15c55e65c26a3af7aa3171032e","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-30T17:37:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update relevant README files","shortMessageHtmlLink":"Update relevant README files"}},{"before":"3f048ce11fdedf4ccfcfa85773157d9c6ce8c9fe","after":"cb4185c18a3673ef843b15ab6b8af162788f0cec","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-30T16:52:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update relevant README files","shortMessageHtmlLink":"Update relevant README files"}},{"before":"356a864676dc2252575bdc0044c357807a48daad","after":"3f048ce11fdedf4ccfcfa85773157d9c6ce8c9fe","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-30T15:53:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update relevant README files","shortMessageHtmlLink":"Update relevant README files"}},{"before":"7d7e3b07cd3ae377b43213965ae295240d3a8dd8","after":"356a864676dc2252575bdc0044c357807a48daad","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-30T15:49:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update relevant README files","shortMessageHtmlLink":"Update relevant README files"}},{"before":"662c6b3d8db6a64213b45319151782981582333d","after":"7d7e3b07cd3ae377b43213965ae295240d3a8dd8","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-30T15:47:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update relevant README files","shortMessageHtmlLink":"Update relevant README files"}},{"before":null,"after":"7d7e3b07cd3ae377b43213965ae295240d3a8dd8","ref":"refs/heads/redo-refactor","pushedAt":"2023-08-30T15:45:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Update relevant README files","shortMessageHtmlLink":"Update relevant README files"}},{"before":null,"after":"662c6b3d8db6a64213b45319151782981582333d","ref":"refs/heads/nix-debug-mode-backup","pushedAt":"2023-08-30T15:43:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Remove docker infrastructure","shortMessageHtmlLink":"Remove docker infrastructure"}},{"before":"ea629f5d3464e9ffba8117653aee3d106671c46e","after":"662c6b3d8db6a64213b45319151782981582333d","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-29T14:44:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Remove docker infrastructure","shortMessageHtmlLink":"Remove docker infrastructure"}},{"before":"5d09131bbef3f1d487e33126cd71d47f1d0b0b73","after":"ea629f5d3464e9ffba8117653aee3d106671c46e","ref":"refs/heads/nix-debug-mode","pushedAt":"2023-08-28T20:38:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"spencerkclark","name":"Spencer Clark","path":"/spencerkclark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6628425?s=80&v=4"},"commit":{"message":"Restore -finit-logical=true compiler flag in debug mode\n\nWe will instead mark the restart reproducibility tests as xfail in debug mode.","shortMessageHtmlLink":"Restore -finit-logical=true compiler flag in debug mode"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyMy0xMS0wMlQyMToyNToyMi4wMDAwMDBazwAAAAOmP0ay","endCursor":"Y3Vyc29yOnYyOpK7MjAyMy0wOC0yOFQyMDozODozOS4wMDAwMDBazwAAAAN0VQ-u"}},"title":"Activity ยท ai2cm/fv3gfs-fortran"}