Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Twitter Documentation #559

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

grallc
Copy link
Contributor

@grallc grallc commented Nov 24, 2024

Relates to:

#558

Risks

Low

Background

Faced auth issues trying to setup a twitter client with cookies

What does this PR do?

Changes the docs to the correct cookies format.
Also added a (not really important) line about other env variables when using cookies.

What kind of change is this?

Documentation

Why are we doing this? Any context or related work?

Documentation misleading, causes error when trying to use it

Documentation changes needed?

If a docs change is needed: I have updated the documentation accordingly.

Testing

Where should a reviewer start?

Just try to setup a twitter client using the format provided in the docs.

Detailed testing steps

Cheers, thanks for the amazing work

@lalalune lalalune merged commit 666d5c1 into elizaOS:main Nov 24, 2024
@oxSaturn
Copy link
Contributor

oxSaturn commented Dec 5, 2024

@grallc Hi, are you sure TWITTER_PASSWORD and TWITTER_EMAIL won't be needed when TWITTER_COOKIES is presented?

From what I saw here https://github.com/ai16z/eliza/blob/0a03140ba7fe18063958e6ffad362f9e3db56b72/packages/client-twitter/src/base.ts#L177-L194, it will always request the password and email address even if I had cookies set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants