From 465c45fc9d36c078f808d26c238b3cd5462b60aa Mon Sep 17 00:00:00 2001 From: Jason Siegel Date: Thu, 15 Dec 2022 23:26:55 -0500 Subject: [PATCH] split voltage maximum and minumum from voltages used to calculate stoich windows for 0 and 100% SOC --- pybamm/input/parameters/lithium_ion/Ai2020.py | 4 ++-- pybamm/input/parameters/lithium_ion/Chen2020.py | 4 ++-- pybamm/input/parameters/lithium_ion/Chen2020_composite.py | 4 ++-- pybamm/input/parameters/lithium_ion/Ecker2015.py | 4 ++-- pybamm/input/parameters/lithium_ion/Marquis2019.py | 4 ++-- pybamm/input/parameters/lithium_ion/Mohtat2020.py | 4 ++-- pybamm/input/parameters/lithium_ion/NCA_Kim2011.py | 4 ++-- pybamm/input/parameters/lithium_ion/OKane2022.py | 4 ++-- pybamm/input/parameters/lithium_ion/ORegan2022.py | 4 ++-- pybamm/input/parameters/lithium_ion/Prada2013.py | 4 ++-- pybamm/input/parameters/lithium_ion/Ramadass2004.py | 4 ++-- pybamm/input/parameters/lithium_ion/Xu2019.py | 4 ++-- pybamm/parameters/electrical_parameters.py | 4 ++-- 13 files changed, 26 insertions(+), 26 deletions(-) diff --git a/pybamm/input/parameters/lithium_ion/Ai2020.py b/pybamm/input/parameters/lithium_ion/Ai2020.py index f6d7461d1c..2b701c7a3e 100644 --- a/pybamm/input/parameters/lithium_ion/Ai2020.py +++ b/pybamm/input/parameters/lithium_ion/Ai2020.py @@ -703,8 +703,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 3.0, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 3.0, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 3.0, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in negative electrode [mol.m-3]": 24108.0, "Initial concentration in positive electrode [mol.m-3]": 21725.0, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/Chen2020.py b/pybamm/input/parameters/lithium_ion/Chen2020.py index 893b495c84..005017dcc6 100644 --- a/pybamm/input/parameters/lithium_ion/Chen2020.py +++ b/pybamm/input/parameters/lithium_ion/Chen2020.py @@ -356,8 +356,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.5, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 2.5, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 2.5, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in negative electrode [mol.m-3]": 29866.0, "Initial concentration in positive electrode [mol.m-3]": 17038.0, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/Chen2020_composite.py b/pybamm/input/parameters/lithium_ion/Chen2020_composite.py index 8a4c4bd9ac..a6fe1c6746 100644 --- a/pybamm/input/parameters/lithium_ion/Chen2020_composite.py +++ b/pybamm/input/parameters/lithium_ion/Chen2020_composite.py @@ -471,8 +471,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.5, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 2.5, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 2.5, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in negative electrode [mol.m-3]": 29866.0, "Initial concentration in positive electrode [mol.m-3]": 17038.0, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/Ecker2015.py b/pybamm/input/parameters/lithium_ion/Ecker2015.py index 44d82157eb..5ff9ffd44a 100644 --- a/pybamm/input/parameters/lithium_ion/Ecker2015.py +++ b/pybamm/input/parameters/lithium_ion/Ecker2015.py @@ -562,8 +562,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.5, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 2.5, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 2.5, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in negative electrode [mol.m-3]": 26120.05, "Initial concentration in positive electrode [mol.m-3]": 12630.8, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/Marquis2019.py b/pybamm/input/parameters/lithium_ion/Marquis2019.py index 948c03128e..2c14e37bf8 100644 --- a/pybamm/input/parameters/lithium_ion/Marquis2019.py +++ b/pybamm/input/parameters/lithium_ion/Marquis2019.py @@ -496,8 +496,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 3.105, "Upper voltage cut-off [V]": 4.1, - "Open circuit potential at 0% [V]": 3.105, - "Open circuit potential at 0% SOC [V]": 4.1, + "Open circuit potential at 0% SOC [V]": 3.105, + "Open circuit potential at 100% SOC [V]": 4.1, "Initial concentration in negative electrode [mol.m-3]": 19986.609595075, "Initial concentration in positive electrode [mol.m-3]": 30730.7554385565, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/Mohtat2020.py b/pybamm/input/parameters/lithium_ion/Mohtat2020.py index 63ee250c13..d1e324e3b6 100644 --- a/pybamm/input/parameters/lithium_ion/Mohtat2020.py +++ b/pybamm/input/parameters/lithium_ion/Mohtat2020.py @@ -497,8 +497,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.8, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 2.8, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 2.8, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in negative electrode [mol.m-3]": 48.8682, "Initial concentration in positive electrode [mol.m-3]": 31513.0, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/NCA_Kim2011.py b/pybamm/input/parameters/lithium_ion/NCA_Kim2011.py index fbc0b12c0e..9220ea1db1 100644 --- a/pybamm/input/parameters/lithium_ion/NCA_Kim2011.py +++ b/pybamm/input/parameters/lithium_ion/NCA_Kim2011.py @@ -437,8 +437,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.7, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 2.7, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 2.7, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in negative electrode [mol.m-3]": 18081.0, "Initial concentration in positive electrode [mol.m-3]": 20090.0, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/OKane2022.py b/pybamm/input/parameters/lithium_ion/OKane2022.py index 1d7afa3ece..c38813da10 100644 --- a/pybamm/input/parameters/lithium_ion/OKane2022.py +++ b/pybamm/input/parameters/lithium_ion/OKane2022.py @@ -676,8 +676,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.5, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 2.5, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 2.5, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in negative electrode [mol.m-3]": 29866.0, "Initial concentration in positive electrode [mol.m-3]": 17038.0, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/ORegan2022.py b/pybamm/input/parameters/lithium_ion/ORegan2022.py index d351bdacbc..83ad4379f6 100644 --- a/pybamm/input/parameters/lithium_ion/ORegan2022.py +++ b/pybamm/input/parameters/lithium_ion/ORegan2022.py @@ -1037,8 +1037,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.5, "Upper voltage cut-off [V]": 4.4, - "Open circuit potential at 0% [V]": 2.5, - "Open circuit potential at 0% SOC [V]": 4.4, + "Open circuit potential at 0% SOC [V]": 2.5, + "Open circuit potential at 100% SOC [V]": 4.4, "Initial concentration in negative electrode [mol.m-3]": 28866.0, "Initial concentration in positive electrode [mol.m-3]": 13975.0, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/Prada2013.py b/pybamm/input/parameters/lithium_ion/Prada2013.py index 862fbe460a..7d39ce06a8 100644 --- a/pybamm/input/parameters/lithium_ion/Prada2013.py +++ b/pybamm/input/parameters/lithium_ion/Prada2013.py @@ -329,8 +329,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.0, "Upper voltage cut-off [V]": 4.4, - "Open circuit potential at 0% [V]": 2.0, - "Open circuit potential at 0% SOC [V]": 4.4, + "Open circuit potential at 0% SOC [V]": 2.0, + "Open circuit potential at 100% SOC [V]": 4.4, "Initial concentration in negative electrode [mol.m-3]": 28831.45783, "Initial concentration in positive electrode [mol.m-3]": 35.3766672, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/Ramadass2004.py b/pybamm/input/parameters/lithium_ion/Ramadass2004.py index ac826260f4..ddbdff8565 100644 --- a/pybamm/input/parameters/lithium_ion/Ramadass2004.py +++ b/pybamm/input/parameters/lithium_ion/Ramadass2004.py @@ -508,8 +508,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 2.8, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 2.8, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 2.8, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in negative electrode [mol.m-3]": 22610.7, "Initial concentration in positive electrode [mol.m-3]": 25777.5, "Initial temperature [K]": 298.15, diff --git a/pybamm/input/parameters/lithium_ion/Xu2019.py b/pybamm/input/parameters/lithium_ion/Xu2019.py index 7e94dea6b0..65e5877e3d 100644 --- a/pybamm/input/parameters/lithium_ion/Xu2019.py +++ b/pybamm/input/parameters/lithium_ion/Xu2019.py @@ -317,8 +317,8 @@ def get_parameter_values(): "Number of cells connected in series to make a battery": 1.0, "Lower voltage cut-off [V]": 3.5, "Upper voltage cut-off [V]": 4.2, - "Open circuit potential at 0% [V]": 3.5, - "Open circuit potential at 0% SOC [V]": 4.2, + "Open circuit potential at 0% SOC [V]": 3.5, + "Open circuit potential at 100% SOC [V]": 4.2, "Initial concentration in positive electrode [mol.m-3]": 4631.0, "Initial temperature [K]": 298.15, # citations diff --git a/pybamm/parameters/electrical_parameters.py b/pybamm/parameters/electrical_parameters.py index 599ca07d5b..a554e24281 100644 --- a/pybamm/parameters/electrical_parameters.py +++ b/pybamm/parameters/electrical_parameters.py @@ -43,9 +43,9 @@ def _set_dimensional_parameters(self): self.voltage_high_cut_dimensional = pybamm.Parameter( "Upper voltage cut-off [V]" ) - self.opc_soc_0_dimensional = pybamm.Parameter("Open circuit potential at 0% [V]") + self.opc_soc_0_dimensional = pybamm.Parameter("Open circuit potential at 0% SOC [V]") self.opc_soc_100_dimensional = pybamm.Parameter( - "Open circuit potential at 0% SOC [V]" + "Open circuit potential at 100% SOC [V]" ) # Current as a function of *dimensional* time. The below is overwritten in # lithium_ion_parameters.py and lead_acid_parameters.py to use the correct