Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does this package depend on grpc? #40

Closed
murgatroid99 opened this issue May 10, 2019 · 1 comment
Closed

Why does this package depend on grpc? #40

murgatroid99 opened this issue May 10, 2019 · 1 comment

Comments

@murgatroid99
Copy link

With grpc-tools, the expected usage pattern is that the generated code will live in the user's package, which will directly depend on grpc and google-protobuf. The README of this package seems to say that it is just doing additional typescript code generation on top of what grpc-tools generates. Is the expected usage pattern the same, or is there some reason I'm missing that this package depends on grpc directly?

@agreatfool
Copy link
Owner

Yes, you are correct. I just check the codes, there is no need to add the grpc in the dependency. I just removed it. Latest version 2.5.1 released.

Thank you for the notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants